Tweak error testing

r-lib · Nov 29, 2023 · 9849619 · 9849619
1 parent 6fb3ab5
commit 9849619
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/tests/testthat/_snaps/xml_find.md b/tests/testthat/_snaps/xml_find.md
@@ -4,7 +4,21 @@
 
 # xml_find_int errors with non integer results
 
-    Element at path `//z` must be a whole number, not a <xml_missing> object.
+    Code
+      xml_find_int(x, "//z")
+    Condition
+      Error in `xml_find_int()`:
+      ! Element at path `//z` must be a whole number, not a <xml_missing> object.
+    Code
+      xml_find_int(x, "//y")
+    Condition
+      Error in `xml_find_int()`:
+      ! Element at path `//y` must be a whole number, not a list.
+    Code
+      xml_find_int(x, "number(1.1)")
+    Condition
+      Error in `xml_find_int()`:
+      ! Element at path `number(1.1)` must be a whole number, not the number 1.1.
 
 # xml_find_chr errors with non character results
 

diff --git a/tests/testthat/test-xml_find.R b/tests/testthat/test-xml_find.R
@@ -88,11 +88,9 @@ test_that("xml_find_num returns a numeric result", {
 # Find int ---------------------------------------------------------------------
 test_that("xml_find_int errors with non integer results", {
   x <- read_xml("<x><y/><y/></x>")
-  expect_snapshot_error({
+  expect_snapshot(error = TRUE, {
     xml_find_int(x, "//z")
     xml_find_int(x, "//y")
-    xml_find_int(x, "1=1")
-    xml_find_int(x, "string(5)")
     xml_find_int(x, "number(1.1)")
   })
 })