address #175

r-spatial · Jan 13, 2025 · 0bd77e5 · 0bd77e5
1 parent b61f6b1
commit 0bd77e5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/R/components.R b/R/components.R
@@ -15,8 +15,8 @@ n.comp.nb <- function(nb.obj){
   }
   if (!igraph) {
     if (!nb.sym) nb.obj <- make.sym.nb(nb.obj)
-    comp <- rep(0,length(nb.obj))
-    comp <- .Call("g_components", nb.obj, as.integer(comp), PACKAGE="spdep")
+    comp0 <- rep(0,length(nb.obj))
+    comp <- .Call("g_components", nb.obj, as.integer(comp0), PACKAGE="spdep")
     answ <- list(nc=length(unique(comp)), comp.id=comp)
   } else {
     stopifnot(requireNamespace("igraph", quietly=TRUE))

diff --git a/src/dfs_ncomp.c b/src/dfs_ncomp.c
@@ -7,7 +7,11 @@
 #define WHITE 0
 
 void dfs(SEXP nblst, SEXP cmpnm, SEXP visited, int curcmp, int nodeid){
-  int n,i;
+  int n,i,nvert;
+
+  if (nodeid < 0 || nodeid >= Rf_length(nblst))
+    Rf_error("n.comp.nb: recursive nodeid out of bounds\ninstall spatialreg and igraph to avoid legacy issue");
+
 
   INTEGER(cmpnm)[nodeid]=curcmp;
   INTEGER(visited)[nodeid]=BLACK;