Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to stable2407 #14

Merged
merged 7 commits into from
Nov 8, 2024
Merged

chore: upgrade to stable2407 #14

merged 7 commits into from
Nov 8, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Nov 4, 2024

With this template, we’re taking a different approach compared to our usual workflow for other templates.
Directly upgraded to a stable version.
The psvm -v "stable2407" command was not used due to various compilation errors; instead, importing directly from the GitHub repository and the latest in https://github.com/polkadot-evm/frontier which is stable2407.

References used to compare

Base Parachain: r0gue-io/base-parachain@polkadot-v1.9.0...polkadot-stable2409
OpenZeppelin/polkadot-runtime-templates#299
polkadot-evm/frontier#1504

Testing

To test everything works, I followed the OpenZeppelin tutorial to deploy a "Hello World" smart contract: https://docs.openzeppelin.com/substrate-runtimes/2.0.2/guides/testing_with_zombienet#step_2_deploy_a_solidity_smart_contract
I added two accounts with balances in the chain_spec file to simplify the testing process above.

chungquantin

This comment was marked as outdated.

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Compiled and block produced successfully.
  • Have you tried to deploy a Solidity contract? I tried evm.create() and it keeps loading forever. Maybe I did something wrong, just want to confirm.

node/src/service.rs Outdated Show resolved Hide resolved
Copy link

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build the project and deploy a contract without problems with the provided steps.
Here a screenshots as proof :)

image

forge create --rpc-url http://localhost:40751 --private-key 0x5fb92d6e98884f76de468fa3f6278f8807c48bebc13595d45af5bdc4da702133 HelloWorld.sol:HelloWorld
[⠊] Compiling...
[⠒] Compiling 1 files with Solc 0.8.28
[⠊] Installing Solc version 0.8.28
[⠢] Successfully installed Solc 0.8.28
[⠆] Solc 0.8.28 finished in 935.67ms
Compiler run successful!
Deployer: 0xf24FF3a9CF04c71Dbc94D0b566f7A27B94566cac
Deployed to: 0x970951a12F975E6762482ACA81E57D5A2A4e73F4
Transaction hash: 0x6f3dc7259690144f48b2142380b0757debd1dabe1e7a46fdd966a3ea1441b36b

@chungquantin chungquantin self-requested a review November 8, 2024 08:34
Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@al3mart al3mart merged commit 45ec1c8 into main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants