Skip to content

feat(pop-api): errors #15

feat(pop-api): errors

feat(pop-api): errors #15

GitHub Actions / clippy succeeded Mar 5, 2024 in 0s

clippy

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check warning on line 383 in node/src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (14/7)

warning: this function has too many arguments (14/7)
   --> node/src/service.rs:368:1
    |
368 | / fn start_consensus(
369 | |     client: Arc<ParachainClient>,
370 | |     block_import: ParachainBlockImport,
371 | |     prometheus_registry: Option<&Registry>,
...   |
382 | |     announce_block: Arc<dyn Fn(Hash, Option<Vec<u8>>) + Send + Sync>,
383 | | ) -> Result<(), sc_service::Error> {
    | |__________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
8  | |
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 19 in runtime/src/extensions/pop_api_extension.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `convert_err` is never used

warning: function `convert_err` is never used
  --> runtime/src/extensions/pop_api_extension.rs:19:4
   |
19 | fn convert_err(err_msg: &'static str) -> impl FnOnce(DispatchError) -> DispatchError {
   |    ^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 31 in runtime/src/extensions/ext_impl/read_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable pattern

warning: unreachable pattern
  --> runtime/src/extensions/ext_impl/read_state.rs:31:9
   |
31 |         _ => Err(DispatchError::Other("Unable to read provided key.")),
   |         ^
   |
   = note: `#[warn(unreachable_patterns)]` on by default

Check warning on line 191 in runtime/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this is a decimal constant

warning: this is a decimal constant
   --> runtime/src/lib.rs:191:19
    |
191 |     spec_version: 00_01_00,
    |                   ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
    = note: `#[warn(clippy::zero_prefixed_literal)]` on by default
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
    |
191 |     spec_version: 1_00,
    |                   ~~~~
help: if you mean to use an octal constant, use `0o`
    |
191 |     spec_version: 0o1_00,
    |                   ~~~~~~

Check warning on line 1 in runtime/src/extensions/ext_impl/read_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `codec::Decode`

warning: unused import: `codec::Decode`
 --> runtime/src/extensions/ext_impl/read_state.rs:1:5
  |
1 | use codec::Decode;
  |     ^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 25 in pop-api/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type alias `MaxTips` is never used

warning: type alias `MaxTips` is never used
  --> pop-api/src/lib.rs:25:6
   |
25 | type MaxTips = u32;
   |      ^^^^^^^

Check warning on line 24 in pop-api/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type alias `KeyLimit` is never used

warning: type alias `KeyLimit` is never used
  --> pop-api/src/lib.rs:24:6
   |
24 | type KeyLimit = u32;
   |      ^^^^^^^^

Check warning on line 22 in pop-api/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type alias `Signature` is never used

warning: type alias `Signature` is never used
  --> pop-api/src/lib.rs:22:6
   |
22 | type Signature = MultiSignature;
   |      ^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 8 in pop-api/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this import is redundant

warning: this import is redundant
 --> pop-api/src/lib.rs:8:1
  |
8 | use scale;
  | ^^^^^^^^^^ help: remove it entirely
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
  = note: `#[warn(clippy::single_component_path_imports)]` on by default