Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get ci pipelines functional, and switch to ruff linter/formatter #264

Merged
merged 96 commits into from
Feb 17, 2025
Merged

get ci pipelines functional, and switch to ruff linter/formatter #264

merged 96 commits into from
Feb 17, 2025

Conversation

rippleFCL
Copy link
Contributor

@rippleFCL rippleFCL commented Mar 22, 2024 •
edited by tigattack
Loading

Initial Checklist

  • Has @tigattack / @issy been added as a reviewer?
  • If applicable, have the relevant project(s), milestone(s), and label(s) been applied?
  • If applicable, have you added details of the cog to the readme as per README.md?

Details

Does this resolve an issue?

  • Switched linting & type analysis to ruff and pyright respectively.
  • Added pre-commit for linting, formatting, and type analysis. This replaces most of the VSCode tasks that are currently included in the repo.
  • Formatted all code with Ruff.
  • Fixed lint & type issues in all cogs.
  • Added a CI job to create code annotations for fixme's and todo's.

@tigattack tigattack self-requested a review March 22, 2024 12:06
@tigattack tigattack added the ci label Mar 22, 2024
tigattack
tigattack reviewed Mar 22, 2024
View reviewed changes
tigattack
tigattack reviewed Mar 22, 2024
View reviewed changes
@issy
Copy link
Member

issy commented Mar 22, 2024

Why autopep8 over black? Is there actually a tangible improvement here?

@rippleFCL
Copy link
Contributor Author

rippleFCL commented Mar 22, 2024 •
edited
Loading

main things id say are, black isnt compatible with pep8 or flake8. it also formats quotes to double quotes and it removes trailing commas. secondly (kinda unrelated) me and tig are thinking abt precommit formatting. currently the repo is more autopep8 compliant than it is black. also if we are using flake8 for linting, precommit formatting with black might cause issues there

@issy
Copy link
Member

issy commented Mar 22, 2024

Yeah fair enough I guess. Sounds good

@issy
Copy link
Member

issy commented Mar 22, 2024

While we're in the area, it might be a good time to version lock the CI dependencies. Reproducible builds are good

@rippleFCL rippleFCL marked this pull request as draft March 23, 2024 02:22
@rippleFCL
Copy link
Contributor Author

so just for comment here i undid the decision on black vs autopep8 after bit more digging the linters can be made to play nice with black, i forgot how much easier black formated code is to read

@rippleFCL rippleFCL marked this pull request as ready for review May 3, 2024 12:49
@rippleFCL rippleFCL changed the title fixing the pylint pipeline and switched linters to autopep8 fixing the pylint pipeline and switched linters to black May 3, 2024
tigattack
tigattack reviewed May 3, 2024
View reviewed changes
tigattack
tigattack reviewed May 3, 2024
View reviewed changes
@rippleFCL rippleFCL changed the title fixing the pylint pipeline and switched linters to black get ci pipelines functional, and switch to ruff linter/formatter May 13, 2024
@rippleFCL
Copy link
Contributor Author

rippleFCL commented Feb 15, 2025 •
edited
Loading

absolutly no clue abt the ruff run??
seams to be triggering a false positive

@rippleFCL
Copy link
Contributor Author

huzzah!!!

@rippleFCL rippleFCL mentioned this pull request Feb 16, 2025
Merged
3 tasks
tigattack
tigattack requested changes Feb 16, 2025
View reviewed changes
@rippleFCL rippleFCL requested a review from tigattack February 17, 2025 03:55
tigattack
tigattack previously approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@tigattack tigattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo. Thanks @rippleFCL ❤️

rippleFCL and others added 19 commits February 17, 2025 04:43
@rippleFCL @tigattack
ci(action): changed name to be generic to version
0391258 
Co-authored-by: tigattack <[email protected]>
@rippleFCL @tigattack
refactor(autoreact): dont import directly from ns when its avaliable
f4e5555 
Co-authored-by: tigattack <[email protected]>
@rippleFCL @tigattack
fix(autoreact): remove unused imports
273ecfb 
Co-authored-by: tigattack <[email protected]>
@rippleFCL
chore(flake8): remove unused flake8 config
e386afc
@rippleFCL
refactor: remove requirements-ci and merged it into requirements-dev
379d45b
@rippleFCL
ci(ci): lock pyright to lint with python version 3.11
ed2d898
@rippleFCL
refactor(role_welcome): remove line breaks from doc strings
0ebf191 
Prior to this change, the line breaks in the docstring will mess up the help formatting for the command
@rippleFCL
chore(extentions): removed mypy and added pre-commit extentions
c8f034e
@rippleFCL
refactor(enforcer): add error handling for invalid and missing channels
768f731
@rippleFCL
refactor(README): chang linting section to must pass ci befor merge
87f4a30
@rippleFCL
refactor(tags): add tag creation back
e3a9487
@rippleFCL
refactor(pyproject): remove unnecessary comment
f29c293
@rippleFCL
refactor(quotes): add fixme to a bad implimentation
8624d25
@rippleFCL
refactor(reactrole): add error handling to reactrole list
e4d01c7
@rippleFCL
refactor(report): log to logger out if no log channel is set
a1cc584
@rippleFCL
refactor(role_welcome): remove old note that no longer applies
1adaa44
@rippleFCL
refactor(timeout): log to logger if channel not found
c420a64
@rippleFCL
refactor(verify): add fallback logging if channels are missing
3c84357
@rippleFCL
ci(ci): added fixmes notifier
f99406f
@tigattack tigattack mentioned this pull request Feb 17, 2025
Closed
@rippleFCL
ci(ci): i have entered the pipeline
e7f6e83 
added my fork of fixme check that dosnt error but still outputs annotations
@rippleFCL rippleFCL requested a review from tigattack February 17, 2025 06:34
@rippleFCL
Copy link
Contributor Author

the code is good now!

@tigattack tigattack merged commit 408fbe4 into rHomelab:main Feb 17, 2025
5 checks passed
This was referenced Feb 17, 2025
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigattack tigattack tigattack approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rippleFCL @issy @tigattack