Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore types and quote them instead #306

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

rippleFCL
Copy link
Contributor

@rippleFCL rippleFCL commented Feb 17, 2025

Initial Checklist

  • Has @tigattack been added as a reviewer?
  • If applicable, have the relevant project(s), milestone(s), and label(s) been applied?
  • If applicable, have you added details of the cog to the readme as per README.md?

Details

Does this resolve an issue?
Resolves #304

Additional

#302 and #303 switched to runtime available types for a hotfix. These are incorrect.

This change switches back to the original correct types but quotes them so it doesn't cause runtime issues.

Prior to this change, rHomelab#302 and rHomelab#303 switched to runtime available types, these are incorrect

This change, switches back to the original correct types but quotes them so it dosnt cause
runtime issues
@tigattack tigattack changed the title fix: restore types and quote them insted fix: restore types and quote them instead Feb 17, 2025
@tigattack tigattack self-requested a review February 17, 2025 17:30
@tigattack tigattack merged commit 21389b4 into rHomelab:main Feb 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] topic cog broken
2 participants