Bugfix: testWaitFor flakiness #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasberik
changed the title
ra1028
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Fixing a flaky test that was reproduced locally at
(Iteration 587 of 1000). Current configuration seem to have no hard time limit, so it might be better to set time limit to decrease CI time in case of flaky tests that are stuck inawait.Main suspect of flakiness is Task with 0s sleep is executed before following await has started, meaning its value is greater than 0 already. Increasing first iteration sleep duration to any value above 0 would help to drastically decrease this flakiness.
Also increased the divider from 10 to 100, because this test's average execution time is 0.3s already, and it would increase further with
1...3.Output
10000 iteration of tests didnt show degradation / flakiness, and average test execution duration is decreased to
0.1375from0.3