Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API reference and Build/Publish workflows #904

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

Zerpet
Copy link
Contributor

@Zerpet Zerpet commented Nov 4, 2024

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

  • Fix API ref workflow
  • Removed unused dev manifest generation

Additional Context

The Build/Test/Publish job was commiting + pushing to the Wiki for every commit. During the re-work of that pipeline,
we stopped pushing to the Wiki for every commit. That unintentionally broke the API reference workflow. The job is green
because the commands succeed, but the outcome is not correct. The simplest solution is to generate the API reference
just before publishing to the Wiki, in the same job.

Previously in build-test-publish, a step would commit an API reference
to the wiki, for every commit. We have moved away from that practice,
and that change broke this workflow. The simplest solution is to
generate the Wiki page from the tag, as part of this workflow.
This was left behind during the pruning of uploading to GCS, and Carvel
package refactor.
@Zerpet Zerpet added this to the v1.16.0 milestone Nov 4, 2024
@Zerpet Zerpet self-assigned this Nov 4, 2024
@Zerpet Zerpet requested a review from MirahImage November 4, 2024 18:46
@Zerpet Zerpet requested review from mkuratczyk and PujaVad November 4, 2024 18:46
@Zerpet Zerpet merged commit a965813 into main Nov 5, 2024
8 checks passed
@Zerpet Zerpet deleted the fix-api-ref-workflow branch November 5, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants