Merge pull request #273 from tomyouyou/illegal_snapshots

Incorrect index version pairs can lead to nodes taking unrecoverable snapshots
rabbitmq · May 9, 2022 · c9b2178 · c9b2178
2 parents 44e04cb + a1b9489
commit c9b2178
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/ra_server.erl b/src/ra_server.erl
@@ -2250,7 +2250,7 @@ apply_with({Idx, Term, {noop, CmdMeta, NextMacVer}},
             %% enable cluster change if the noop command is for the current term
             Cfg = Cfg0#cfg{effective_machine_version = NextMacVer,
                            %% record this machine version "term"
-                           machine_versions = [{Idx, MacVer} | MacVersions],
+                           machine_versions = [{Idx, NextMacVer} | MacVersions],
                            effective_machine_module = Module},
             State = State0#{cfg => Cfg,
                             cluster_change_permitted => ClusterChangePerm},