API consistency with .NET client #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In .NET we have both |
Unfortunately you can't do function overloads like that in golang 😢 @Gsantomaggio should I add a function for strings? |
Yes, of course :)! I was thinking something like: SourceExchange(exchangeSpec IExchangeSpecification) IBindingSpecification
SourceExchangeByName(exchangeName string) IBindingSpecification |
* Prefer using `IQueueSpecification` and `IExchangeSpecification` instead of `string` For bindings, use strings for source and destination names. Add sleep so credit is granted from RMQ (HACK) Add minimal sleep for links to be established * No need to have exported types and functions in `common.go` * Simplify functions and remove `PercentCodec` type Use `fmt.Errorf` Update modules
lukebakken
force-pushed
the
rabbitmq-amqp-go-client-3
branch
from
61736b2
to
b9a14aa
Compare
Gsantomaggio
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IQueueSpecificationandIExchangeSpecificationinstead ofstring