fix: properly cancel token passed to AsyncEventingBasicConsumer receiver #1789
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuijben
reviewed
Feb 21, 2025
|
I started something similar a while ago https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1740/files but never got the chance to fully follow through yet |
…vent on channel close Fixes rabbitmq#1787
lukebakken
force-pushed
the
fix-consumer-token-cancel-on-close
branch
from
73064d2 to
3565e17
Compare
lukebakken
approved these changes
Aug 19, 2025
|
Thanks everyone. I've made some changes if you'd like to look at this again. I'm hoping to get 7.2.0 out this week. |
|
@lukebakken did you have a chance to look at the PR I started? By floating through the token into the args I think it wouldn't be necessary to expose the channel token on the interface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1787