MVP of smart producer #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
force-pushed
the
zerpet/wip-producer-v2
branch
2 times, most recently
from
a66f886 to
947e258
Compare
Signed-off-by: Aitor Pérez Cedres <[email protected]>
First pass for smart producer. Signed-off-by: Aitor Perez Cedres <[email protected]>
GA version of `slog` has a different signature for `slog.New`. This commit updates some code that was using the old signature. Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Internal component to track publisher confirmations. Signed-off-by: Aitor Perez Cedres <[email protected]>
The semaphore provides an simple mechanism to synchronise the addition and release of pending confirmation messages. Given how channels work in Go, the functions to add pending confirmations will block if the semaphore does not have more slots or permits available. Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Channels synchronise naturally, and also act as a synchronised queue. Those two properties make channels an excellent choice to implement a semaphore and a message queue buffer. Signed-off-by: Aitor Perez Cedres <[email protected]>
We want to provide a better abstraction for message confirmations in the smart layer. The publish confirm frame sends a potentially long list of IDs that are confirmed. In the stream protocol, a confirm for ID N does not confirm messages with IDs < N. Therefore, we have to keep track of all pending publishing IDs, and associate them with their AMQP message. Signed-off-by: Aitor Perez Cedres <[email protected]>
To use a local binary version, and avoid changing the system binary for Ginkgo CLI that may be present. The same for MockGen. Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
At the raw layer, the client uses two different commands for publish confirmation and publish error. At the smart layer, we abstract that away and consider a publish error a "nack" or negative publish confirmation. We have to adapt the channel in the producer, so that it can receive publish confirmations or publish errors in the same channel. Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
This component is responsible for keeping track of producers in the environment. This component also sends the relevant frame to the broker, so that the server registers a new publisher. Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
- Producer status - Export Broker references from raw layer - Use metadata query to connect to the stream leader Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
We started developing in Go 1.21 because slog package became GA in Go 1.21. The toolchain directive in go.mod is new and only available in Go 1.21. We have to temporarily bump the Go version in CI to 'stable'. We will provide compatibility to oldstable at a later date. Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Zerpet
force-pushed
the
zerpet/wip-producer-v2
branch
from
7ba9e23 to
3dcf74d
Compare
Signed-off-by: Aitor Perez Cedres <[email protected]>
Zerpet
force-pushed
the
zerpet/wip-producer-v2
branch
from
8b37fa3 to
3ccfcf2
Compare
|
@ablease we can merge this interim work to converge our branches. Then, we can branch off again from a common point. |
Skipping system tests were not actually skipping system tests. Signed-off-by: Aitor Perez Cedres <[email protected]>
Gsantomaggio
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToDo's