fix offset of single active consumer reset to 0 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages have been consumed
SAC offset should be initialized by the ConsumerUpdate func of SAC
Gsantomaggio
requested changes
Jul 22, 2024
Gsantomaggio
approved these changes
Jul 22, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a single active consumer with an offset is closed while no messages have been consumed, the offset 0 is sent to the server when closing the consumer gracefully and auto commit is enabled.
Recently
lastStoredOffsetwas changed to be initialized with -1 for #306 , however that change caused this bug because the offset is only sent whenlastStoredOffset < currentOffset. Because currentOffset is set to 0 by default by offset next and the default 0 initalization,lastStoredOffset < currentOffsetis true when closing the consumer resulting in the offset 0 being sent. Because no messages were consumed either the offset was not populated.