refactor: after second review

raccoongang · May 7, 2024 · f37ef50 · f37ef50
1 parent bc6f9d7
commit f37ef50
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/course-unit/CourseUnit.test.jsx b/src/course-unit/CourseUnit.test.jsx
@@ -1616,7 +1616,7 @@ describe('<CourseUnit />', () => {
 
       userEvent.click(xblockEditBtn);
 
-      const iframePostMsg = getIFramePostMessages('close_edit_modal');
+      const iframePostMsg = getIFramePostMessages('close_modal');
       const editModalIFrame = getByTitle('xblock-edit-modal-iframe');
 
       expect(editModalIFrame).toHaveAttribute('src', `${getConfig().STUDIO_BASE_URL}/xblock/${courseVerticalChildrenMock.children[0].block_id}/actions/edit`);

diff --git a/src/course-unit/course-xblock/CourseXBlock.jsx b/src/course-unit/course-xblock/CourseXBlock.jsx
@@ -86,17 +86,12 @@ const CourseXBlock = memo(({
   useEffect(() => {
     const handleMessage = (event) => {
       const { method, params } = event.data;
-
-      if (method === 'close_edit_modal') {
+      console.log('method', method);
+      if (method === 'close_modal') {
         toggleLegacyEditModal(false);
         dispatch(fetchCourseVerticalChildrenData(blockId));
         dispatch(fetchXBlockIFrameHtmlAndResourcesQuery(id));
         dispatch(fetchCourseUnitQuery(blockId));
-      } else if (method === 'close_move_modal') {
-        toggleLegacyMoveModal(false);
-        dispatch(fetchCourseVerticalChildrenData(blockId));
-        dispatch(fetchXBlockIFrameHtmlAndResourcesQuery(id));
-        dispatch(fetchCourseUnitQuery(blockId));
       } else if (method === 'move_xblock') {
         toggleLegacyMoveModal(false);
         dispatch(updateMovedXBlockParams({