Improve tests

rack · Oct 17, 2023 · 4a91cd7 · 4a91cd7
1 parent 3fcf9cf
commit 4a91cd7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/spec/acceptance/blocking_ip_spec.rb b/spec/acceptance/blocking_ip_spec.rb
@@ -14,6 +14,12 @@
   end
 
   it "succeeds if IP doesn't match" do
+    get "/", {}, "REMOTE_ADDR" => "5.6.7.8"
+
+    assert_equal 200, last_response.status
+  end
+
+  it "succeeds if IP is missing" do
     get "/", {}, "REMOTE_ADDR" => ""
 
     assert_equal 200, last_response.status

diff --git a/spec/acceptance/safelisting_ip_spec.rb b/spec/acceptance/safelisting_ip_spec.rb
@@ -12,6 +12,12 @@
   end
 
   it "forbids request if blocklist condition is true and safelist is false" do
+    get "/admin", {}, "REMOTE_ADDR" => "1.2.3.4"
+
+    assert_equal 403, last_response.status
+  end
+
+  it "forbids request if blocklist condition is true and safelist is false (missing IP)" do
     get "/admin", {}, "REMOTE_ADDR" => ""
 
     assert_equal 403, last_response.status