add skipVerifyApp param to trackVerified() and startTrackingVerified() #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kochis
reviewed
Oct 10, 2024
Comment on lines
-24
to
-25
| const deviceId = params.deviceId || Device.getDeviceId(); | ||
| const installId = params.installId || Device.getInstallId(); |
There was a problem hiding this comment.
Why the change to get rid of setting these via params? This might be how we override the values int the simulator.
There was a problem hiding this comment.
I don't really want to give developers control of these for fraud / geo-compliance use cases. For implementations using the Mac and Windows app, those apps override these anyway (with more stable hardware device IDs)
kochis
reviewed
Oct 10, 2024
src/api/verify.ts
Outdated
| @@ -103,7 +116,9 @@ class VerifyAPI { | |||
|
|
|||
| static async startTrackingVerified(params: RadarStartTrackingVerifiedParams) { | |||
| const doTrackVerified = async () => { | |||
| const trackRes = await this.trackVerified({}); | |||
| const trackRes = await this.trackVerified({ | |||
| ...params, | |||
There was a problem hiding this comment.
nit: can probably just pass params instead of destructuring
There was a problem hiding this comment.
Good call, updated
kochis
previously approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.