chore: upgrade typescript and use --isolatedDeclarations (#39)

.github/workflows/publish-beta.yml

@@ -151,6 +151,6 @@ jobs:
 
       - name: Publish to JSR
         run: |
-          deno run -A jsr:@david/[email protected] --allow-slow-types --allow-dirty
+          deno run -A jsr:@david/[email protected] --allow-dirty
         env:
           GITHUB_REF: refs/tags/v${{ needs.prepare-version.outputs.version }}

.vscode/settings.json

@@ -6,6 +6,8 @@
     "source.organizeImports",
     "source.formatDocument"
   ],
+  "typescript.tsdk": "./node_modules/typescript/lib",
+  "typescript.enablePromptUseWorkspaceTsdk": true,
   "typescript.preferences.importModuleSpecifier": "non-relative",
   "typescript.preferences.autoImportFileExcludePatterns": [
     "**/node_modules/**",

package.json

@@ -25,7 +25,7 @@
     "@vitest/coverage-v8": "^1.6.0",
     "prettier": "^2.7.1",
     "tsup": "^8.1.0",
-    "typescript": "^4.8.4",
+    "typescript": "^5.5.2",
     "vitest": "^1.6.0"
   },
   "packageManager": "[email protected]",

src/array/alphabetical.ts

@@ -6,7 +6,7 @@ export function alphabetical<T>(
   array: readonly T[],
   getter: (item: T) => string,
   dir: 'asc' | 'desc' = 'asc',
-) {
+): T[] {
   if (!array) {
     return []
   }

src/array/boil.ts

@@ -7,7 +7,10 @@
  * boil([1, 2, 3, 0], (a, b) => a > b ? a : b) // 3
  * ```
  */
-export function boil<T>(array: readonly T[], compareFunc: (a: T, b: T) => T) {
+export function boil<T>(
+  array: readonly T[],
+  compareFunc: (a: T, b: T) => T,
+): T | null {
   if (!array || (array.length ?? 0) === 0) {
     return null
   }

src/array/first.ts

@@ -9,9 +9,10 @@
  * // 0
  * ```
  */
-export function first<T>(
-  array: readonly T[],
-  defaultValue: T | null | undefined = undefined,
-) {
+export function first<T>(array: readonly T[]): T | undefined
+
+export function first<T, U>(array: readonly T[], defaultValue: U): T | U
+
+export function first(array: readonly unknown[], defaultValue?: unknown) {
   return array?.length > 0 ? array[0] : defaultValue
 }

src/array/iterate.ts

@@ -14,7 +14,7 @@ export function iterate<T>(
   count: number,
   func: (currentValue: T, iteration: number) => T,
   initValue: T,
-) {
+): T {
   let value = initValue
   for (let i = 1; i <= count; i++) {
     value = func(value, i)

src/array/last.ts

@@ -9,9 +9,10 @@
  * // 0
  * ```
  */
-export function last<T>(
-  array: readonly T[],
-  defaultValue: T | null | undefined = undefined,
-) {
+export function last<T>(array: readonly T[]): T | undefined
+
+export function last<T, U>(array: readonly T[], defaultValue: U): T | U
+
+export function last(array: readonly unknown[], defaultValue?: unknown) {
   return array?.length > 0 ? array[array.length - 1] : defaultValue
 }

src/array/merge.ts

@@ -16,18 +16,18 @@ export function merge<T>(
   root: readonly T[],
   others: readonly T[],
   matcher: (item: T) => any,
-) {
+): T[] {
   if (!others && !root) {
     return []
   }
   if (!others) {
-    return root
+    return [...root]
   }
   if (!root) {
     return []
   }
   if (!matcher) {
-    return root
+    return [...root]
   }
   return root.reduce((acc, r) => {
     const matched = others.find(o => matcher(r) === matcher(o))

src/array/replace.ts

@@ -1,6 +1,11 @@
 /**
  * Replace an element in an array with a new item without modifying
  * the array and return the new value
+ *
+ * ```ts
+ * replace([1, 2, 3], 4, (n) => n === 2)
+ * // [1, 4, 3]
+ * ```
  */
 export function replace<T>(
   list: readonly T[],

src/array/replaceOrAppend.ts

@@ -15,7 +15,7 @@ export function replaceOrAppend<T>(
   list: readonly T[],
   newItem: T,
   match: (a: T, idx: number) => boolean,
-) {
+): T[] {
   if (!list && !newItem) {
     return []
   }

src/array/select.ts

@@ -11,21 +11,21 @@
  * // => [9, 16]
  * ```
  */
-export function select<T, K>(
+export function select<T, U>(
   array: readonly T[],
-  mapper: (item: T, index: number) => K,
+  mapper: (item: T, index: number) => U,
   condition?: (item: T, index: number) => boolean,
-) {
+): U[] {
   if (!array) {
     return []
   }
-  let mapped: K
+  let mapped: U
   return array.reduce((acc, item, index) => {
     if (condition) {
       condition(item, index) && acc.push(mapper(item, index))
     } else if ((mapped = mapper(item, index)) != null) {
       acc.push(mapped)
     }
     return acc
-  }, [] as K[])
+  }, [] as U[])
 }

src/array/sort.ts

@@ -17,7 +17,7 @@ export function sort<T>(
   array: readonly T[],
   getter: (item: T) => number,
   desc = false,
-) {
+): T[] {
   if (!array) {
     return []
   }

src/array/toggle.ts

@@ -29,7 +29,7 @@ export function toggle<T>(
   options?: {
     strategy?: 'prepend' | 'append'
   },
-) {
+): T[] {
   if (!list && !item) {
     return []
   }

src/async/tests/retry.test.ts

@@ -8,7 +8,7 @@ describe('_.retry', () => {
     vi.useFakeTimers({ shouldAdvanceTime: true })
   })
   test('returns result of given function', async () => {
-    const result = await _.retry(cast(null), async bail => {
+    const result = await _.retry(cast(null), async _bail => {
       return 'hello'
     })
     expect(result).toBe('hello')
@@ -21,7 +21,7 @@ describe('_.retry', () => {
   })
   test('retries on failure', async () => {
     let failedOnce = false
-    const result = await _.retry(cast(null), async bail => {
+    const result = await _.retry(cast(null), async _bail => {
       if (!failedOnce) {
         failedOnce = true
         throw 'Failing for test'

src/curry/callable.ts

@@ -24,6 +24,6 @@ export function callable<
       ;(target as any)[key] = value
       return true
     },
-    apply: (target, self, args) => fn(Object.assign({}, target))(...args),
+    apply: (target, _, args) => fn(Object.assign({}, target))(...args),
   }) as unknown as TObj & TFunc
 }

src/curry/debounce.ts

@@ -29,7 +29,7 @@ export type DebounceFunction<TArgs extends any[]> = {
 export function debounce<TArgs extends any[]>(
   { delay }: { delay: number },
   func: (...args: TArgs) => any,
-) {
+): DebounceFunction<TArgs> {
   let timer: unknown = undefined
   let active = true
 

src/curry/partial.ts

@@ -30,7 +30,6 @@ type RemoveItemsInFront<
 export function partial<T extends any[], TA extends Partial<T>, R>(
   fn: (...args: T) => R,
   ...args: TA
-) {
-  return (...rest: RemoveItemsInFront<T, TA>) =>
-    fn(...([...args, ...rest] as T))
+): (...rest: RemoveItemsInFront<T, TA>) => R {
+  return (...rest) => fn(...([...args, ...rest] as T))
 }

src/curry/throttle.ts

@@ -16,7 +16,7 @@ export type ThrottledFunction<TArgs extends any[]> = {
 export function throttle<TArgs extends any[]>(
   { interval }: { interval: number },
   func: (...args: TArgs) => any,
-) {
+): ThrottledFunction<TArgs> {
   let ready = true
   let timer: unknown = undefined
 

src/object/listify.ts

@@ -1,10 +1,10 @@
 /**
  * Convert an object to a list, mapping each entry into a list item
  */
-export function listify<TValue, TKey extends string | number | symbol, KResult>(
-  obj: Record<TKey, TValue>,
-  toItem: (key: TKey, value: TValue) => KResult,
-) {
+export function listify<Value, Key extends string | number | symbol, Item>(
+  obj: Record<Key, Value>,
+  toItem: (key: Key, value: Value) => Item,
+): Item[] {
   if (!obj) {
     return []
   }
@@ -13,7 +13,7 @@ export function listify<TValue, TKey extends string | number | symbol, KResult>(
     return []
   }
   return entries.reduce((acc, entry) => {
-    acc.push(toItem(entry[0] as TKey, entry[1] as TValue))
+    acc.push(toItem(entry[0] as Key, entry[1] as Value))
     return acc
-  }, [] as KResult[])
+  }, [] as Item[])
 }