Skip to content

Commit

Permalink
chore: revert markdown trailing space, rename variable
Browse files Browse the repository at this point in the history
  • Loading branch information
adamhamlin authored and aleclarson committed Aug 18, 2024
1 parent 81d4d66 commit ec35109
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ deno add @radashi-org/radashi

## FAQ

- **“I need XYZ, but Radashi doesn't have it.”**
- **“I need XYZ, but Radashi doesn't have it.”**
If you have a need not met by our current set of functions, we want to hear about it. [Start a discussion](https://github.com/orgs/radashi-org/discussions/new?category=ideas) so we can explore the idea together!

- **What does “community first” mean exactly?**
- **What does “community first” mean exactly?**
It means putting the community's needs first, leaning towards adding support for popular use cases, as opposed to being strictly minimalist. As such, your feedback is very welcome and we value your perspective. Specifically, we want you to [contribute your viewpoint](https://github.com/orgs/radashi-org/discussions/categories/rfcs?discussions_q=is%3Aopen+category%3ARFCs) to discussions in our RFCs category.

- **Are my contributions welcome?**
- **Are my contributions welcome?**
Yes! Pull requests are encouraged, but please keep them small and focused. Sweeping changes are discouraged and won't be merged (unless the rationale's been thoroughly discussed).

Please review _“The ethos of Radashi”_ before submitting a pull request:
Expand All @@ -100,24 +100,24 @@ deno add @radashi-org/radashi
<img src="https://github.com/radashi-org/radashi/raw/main/.github/img/ethos-button.png" alt="The ethos of Radashi" width="250px" />
</a>

- **Can I help you maintain this?**
- **Can I help you maintain this?**
Yes! I'll add you as a contributor to the repository. You can review pull requests and even merge them. You can help with closing issues, too. Committing directly to the main branch is a privilege you can earn, as is publishing versions to NPM.

<a href="https://github.com/orgs/radashi-org/discussions/4">
<img src="https://github.com/radashi-org/radashi/raw/main/.github/img/apply-button.png" alt="Apply to join the Radashi team" width="250px" />
</a>

- **Is backwards compatibility a goal?**
- **Is backwards compatibility a goal?**
Yes! We want the transition from `radash` to this library to be smooth. If you're coming from Radash, we recommend installing `radashi@^12`. This version will continue to receive backported fixes even after Radashi v13 is released. You can upgrade to the latest major version when you're ready.

- **Automatic releases**
- **Automatic releases**
To ensure contributions are quickly rolled out, we have the following automatic processes:

- **Beta releases**
- **Beta releases**
Whenever the `main` branch receives a fix or feature, a beta release is automatically published to NPM at 5:00AM UTC.
Installing `radashi@beta` will always fetch the latest beta release. Beta releases are always audited by the Radashi team.

- **Preview releases**
- **Preview releases**
When the _owner of a PR_ comments `/publish` (and nothing more), the PR is published to NPM under a version like `1.0.0-pr123.f7a9c3b` (i.e. `<latest version>-pr<PR number>.<commit SHA>`) and a tag like `pr123`. This allows the community to use the changes in the PR without waiting for the PR to be merged.

- ⚠️ **Beware:** Preview releases are not audited by the Radashi team. Always look at their
Expand Down
6 changes: 3 additions & 3 deletions src/object/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ export function get<TDefault = unknown>(
if (current === undefined) {
return defaultValue as TDefault
}
const withoutQuotes = key.replace(/['"]/g, '')
if (withoutQuotes.trim() === '') {
const unquotedKey = key.replace(/['"]/g, '')
if (unquotedKey.trim() === '') {
continue
}
current = current[withoutQuotes]
current = current[unquotedKey]
}
if (current === undefined) {
return defaultValue as TDefault
Expand Down

0 comments on commit ec35109

Please sign in to comment.