Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mapify): provide an index argument to the callbacks #100

Merged
merged 3 commits into from
Jul 14, 2024

Conversation

aleclarson
Copy link
Member

@aleclarson aleclarson commented Jul 10, 2024

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Summary

Allow mapify callbacks to base their return value on the array index.

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Bundle impact

Status File Size Difference (%)
M src/array/mapify.ts 117 +14 (+13%)

@aleclarson aleclarson force-pushed the main branch 2 times, most recently from 2154f96 to 6a4b4f6 Compare July 12, 2024 00:23
@aleclarson aleclarson added the new feature This PR adds a new function or extends an existing one label Jul 13, 2024
@aleclarson aleclarson marked this pull request as ready for review July 14, 2024 02:17
@aleclarson aleclarson merged commit f010ad4 into main Jul 14, 2024
16 checks passed
@aleclarson aleclarson deleted the feat/mapify-index branch July 14, 2024 02:18
Copy link

A new beta version 12.2.0-beta.c090534 has been published to NPM. 🚀

To install:

The radashi@beta tag also includes this PR.

See the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This PR adds a new function or extends an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant