feat: add promiseDebounce function
#109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
added
the
new feature
aleclarson
commented
Nov 11, 2024
| if (timeout !== undefined) { | ||
| clearTimeout(timeout) | ||
| timeout = undefined | ||
| const oldResolver = resolver |
There was a problem hiding this comment.
Suggested change
| const oldResolver = resolver | |
| const oldResolver = resolver | |
| resolver = undefined |
|
Delaying this until v13, which is when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
It's like
debouncebut each call returns a promise that doesn't resolve unless that call is the last call before the timeout expires. In other words, only when the call finally succeeds, the returned promise will resolve with the function result.Basically, if you have a debounced function whose result could be useful, you'll want to use
promiseDebounceinstead.Naming is not final. Share your thoughts below!
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/curry/promiseDebounce.ts