-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename *ify functions (DO NOT SQUASH) #110
Draft
aleclarson
wants to merge
8
commits into
next
Choose a base branch
from
refactor/transforms
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bdb1bfc.
…and also, move them into "array" group. I plan to remove the existing “casted” function group (moving them to most appropriate type-based groups).
aleclarson
force-pushed
the
refactor/transforms
branch
from
July 14, 2024 19:53
a925326
to
5aa6cc5
Compare
Decided to rename Naming guideline for conversion functions
|
Also renamed Ultimately, the goal is to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
listify
tomapEntriesToArray
objectify
tocastObject
mapify
tocastMap
Addsrc/transform
folder + tests/docs/benchmarks foldersMovetoInt
into the “transform” folders.MovetoFloat
into the “transform” folders.Related issue, if any:
https://github.com/orgs/radashi-org/discussions/65
For any code change,
Does this PR introduce a breaking change?
Yes
A codemod should be written for this change.
Bundle impact
src/array/mapify.ts
A
D
M
D
A