-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup dev containers #138
chore: setup dev containers #138
Conversation
Now that I saw that my PR had several commits that were already merged into the main branch, I don't know if this is a problem. |
Huh, never heard of this. I will try it out tomorrow and get back to you 👍 |
.devcontainer/devcontainer.json
Outdated
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"vitest.explorer", | ||
"biomejs.biome", | ||
"esbenp.prettier-vscode" | ||
], | ||
"settings": { | ||
"editor.formatOnSave": true, | ||
"editor.codeActionsOnSave": { | ||
"source.organizeImports": "explicit", | ||
"quickfix.biome": "explicit" | ||
}, | ||
"typescript.tsdk": "./node_modules/typescript/lib", | ||
"typescript.enablePromptUseWorkspaceTsdk": true, | ||
"typescript.preferences.importModuleSpecifier": "non-relative", | ||
"typescript.preferences.autoImportFileExcludePatterns": [ | ||
"**/node_modules/**", | ||
"**/dist/**", | ||
"**/dist" | ||
], | ||
"[markdown]": { | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
}, | ||
"[mdx]": { | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
}, | ||
"[json]": { | ||
"editor.defaultFormatter": "biomejs.biome" | ||
}, | ||
"[jsonc]": { | ||
"editor.defaultFormatter": "biomejs.biome" | ||
}, | ||
"[typescript]": { | ||
"editor.defaultFormatter": "biomejs.biome", | ||
"rewrap.wrappingColumn": 70 | ||
}, | ||
"[shellscript]": { | ||
"rewrap.wrappingColumn": 70 | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this actually necessary? do dev containers not use .vscode/settings.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the extensions part, yes, because this way when creating the development container they are already installed 😃. but the rest is really an unnecessary duplication.
I think it was my force of habit to leave only the configurations in the dev container.
I'm going to change this
Sorry for the delay (was finishing v1 of the documentation site). Happy to get this one merged once my question is answered :) |
A new beta version To install: pnpm add [email protected] The |
Summary
In my daily work, I use Development Containers for all my applications. This approach is also widely adopted by large teams. Development containers allow us to create a Docker environment tailored for development, complete with a pre-configured operating system, dependencies, packages, extensions, and settings. This greatly facilitates the development process.
I have prepared a contribution that integrates development containers into the project. This setup works with both VSCode and IntelliJ, as well as with online code editors like CodeSandbox and GitHub Codespaces. I believe this configuration would add significant value to the project.
How to test it in Visual Studio Code
dev Containers: open Folder in Container
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact