feat: add withResolvers ponyfill
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All functions in Radashi are public. It's one of our core principles currently. 😉 |
aleclarson
force-pushed
the
add-withResolvers
branch
from
c1e570b to
fd99742
Compare
|
Apologies for the delay. Been working on the Radashi website and its VSCode extension :) I'm gonna use this PR to debug the "Bundle Impact" calculation (it shouldn't be an empty table here), but after that we can merge! |
aleclarson
force-pushed
the
add-withResolvers
branch
3 times, most recently
from
3dc862c to
b8bcc97
Compare
aleclarson
force-pushed
the
add-withResolvers
branch
13 times, most recently
from
51b7083 to
4ff691d
Compare
aleclarson
force-pushed
the
add-withResolvers
branch
from
4ff691d to
ba6af32
Compare
|
A new beta version To install: pnpm add [email protected]The 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
Not sure if that one should be public util or radashi internal one.
Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/async/withResolvers.tsFootnotes
Function size includes the
importdependencies of the function. ↩