-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup config semantical commits #169
chore: setup config semantical commits #169
Conversation
- Keep the tests in one file. Use `vi.resetModules` to check for correct behavior when globalThis.AggregateError is undefined and when it‘s not. - Inline the polyfill so it‘s not instantiated unless necessary. - Rename the local const to `AggregateErrorOrPolyfill` then use `export { … as … }` to export it as `AggregateError`. This prevents ESBuild from renaming the polyfill to `AggregateError2`, which it does to prevent variable shadowing.
…ommit Chore/config semantical commit
This reverts commit ed58471.
Now that I've seen that some commits from the past were in an unacceptable standard. (I fell into my own trap 😄) In this case, I don't know if it would be valid to rewrite old commits from this PR to fit the standard or maybe just skip it this time. The funny thing is that even though I've merged with the main repository, several old commits appear in my PRs |
Thanks for the PR, Marlon! I'll have to decline this suggestion, and here's why: I have a policy to always squash-merge1 pull requests. This gives contributors the freedom to write whatever suits them when committing to their PR, without a pre-commit/pre-push hook “scolding” them. When squash-merging a PR, GitHub uses the PR title as the commit message. I've already set up an automated check that will prevent merging if a PR title does not conform to the Conventional Commits specification. Hopefully that all made sense! 😄 By the way, I want to make sure you know that I really do appreciate the effort you've been putting in. It's really my fault for not better documenting the project setup, including things I've already said "no" to. Keep up the great work! Footnotes |
P.S. It appears your fork's
If that fails, you may want to hard reset to |
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
After the comment on the issue:
I noticed the interest in standardizing commit messages. I set up a basic configuration using Husky and commitlint to validate commit messages, both in the pre-commit stage and in CI.
We can refine and add extra rules in the future, but this PR serves as a starting point for that standardization.
Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No (maybe for contributors 🤣).