fix(crush): support dot in property name

[aleclarson]

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Description

Currently, the crush function combines the objectify and keys functions to achieve its behavior.

The cause of the issue is with keys creating no discernible difference between a property with a dot in it (i.e. {"a.b":1} => "a.b") and a property path of multiple property names (i.e. {a:{b:1}} => "a.b").

As of now, this PR only adds a test case to verify the bug report by @stefaanMLB.

Checklist

• Changes are covered by tests if behavior has been changed or added
• Tests have 100% coverage
• If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves sodiray/radash#365

Bundle impact

Status	File	Size	Difference (%)
M	src/object/crush.ts	2951	-396 (-58%)

Footnotes

1. Function size includes the import dependencies of the function. ↩

[stefaanMLB]

@aleclarson, I fixed the problem but I'm having trouble with the tooling.
Can I get away with using NPM or is there no way around using PNPM ?
After adapting the code I get a lot of errors in the async module which I didn't change 🤔
This is the code that fixes the crush problem, not sure how to proceed from here

type Primitive = number | string | boolean | Date | symbol | bigint | undefined | null;

const crush = <TValue extends object>(value: TValue): Record<string, Primitive> | Record<string, never> => {
  if (!value) return {};
  const crushToPvArray: (obj: object, path: string) => Array<{ p: string; v: Primitive }> = (
    obj: object,
    path: string
  ) =>
    Object.entries(obj).flatMap(([key, value]) =>
      isPrimitive(value) ? { p: path ? `${path}.${key}` : key, v: value } : crushToPvArray(value, `${path}.${key}`)
    );

  return objectify(
    crushToPvArray(value, ''),
    (o) => o.p,
    (o) => o.v
  );
};

[aleclarson]

Hi @stefaanMLB,

If PNPM is causing you trouble locally, you could try using Github codespaces instead. In my experience, PNPM hasn't been hard to use, but I don't know your set up.

If you'd prefer to use NPM, it should be okay, but you don't get the lockfile (which normally isn't a big deal).

npm install --no-package-lock

Feel free to open a new PR with your solution and I'll review it there, thanks.

[stefaanMLB]

@aleclarson, I believe I solved this problem and succeeded to create PR#95.
I'm not accustomed to working with PR's, so please let me know if I did everything correct.
If this one is OK, then I'll be happy to contribute more to the library.

[aleclarson]

Closed in favor of #95