Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve radashi maintenance/ci scripts #315

Merged
merged 26 commits into from
Nov 17, 2024
Merged

chore: improve radashi maintenance/ci scripts #315

merged 26 commits into from
Nov 17, 2024

Conversation

aleclarson
Copy link
Member

@aleclarson aleclarson commented Nov 17, 2024

Summary

  • None of the scripts require Bash to run. Only Node.js is used.
  • If Node.js 22.6+ is installed, scripts are run with node --experimental-strip-types instead of tsx. Otherwise, tsx is used like before.
  • Scripts (and any local packages they depend on) have their node_modules installed on-demand (via the scripts/run.js module), so we can remove fragile pnpm install calls from GitHub workflows.
  • The test-single, test-branch, and checkout-pr scripts have been rewritten in Node.js for better maintainability.
  • All packages in scripts share a single lockfile (by using the --lockfile-dir option of pnpm install).
  • Removed the concept of “preview releases” for PRs. It's recommended to use the radashi-template instead, and import a PR into your Radashi with the pnpm radashi import 123 command (see radashi-helper for details).

Remaining tasks

  • May need to update CONTRIBUTING.md
  • Update the root README.md

Related issue, if any:

Closes #311

In #269, issues with Bash were reported:

I'm currently NOT running on a linux machine and cannot run the linting due to the bash dependecy. I will try to install wsl soon but wont be able to do it now.

@aleclarson aleclarson merged commit 8d31800 into main Nov 17, 2024
8 checks passed
@MarlonPassos-git
Copy link
Contributor

@aleclarson With this PR, the pnpm add-function script now uses the logic from the radashi-helper CLI to generate templates for new functions. However, from my testing, this only works if the project includes a radashi.json file, which, as far as I understand, would only apply to projects using the radashi-template—and that's not the case for the core project.

I mention this because, currently, when trying to use the command, we get this error:
image

Regarding this, I can think of three ways to address the issue:

  • Adapt the CLI to include a flag that removes the need for a radashi.json file.
  • Add a radashi.json file to the core project.
  • Create a standalone script for this specific command.

@aleclarson
Copy link
Member Author

@MarlonPassos-git Oops, thanks for the report! I've made the necessary changes in radashi-helper to support running in a Radashi clone rather than a Radashi template. 🎉

@radashi-bot
Copy link

A stable release 12.3.0 has been published to NPM. 🚀

To install:

See the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants