perf(replace): avoid creating 2 intermediate arrays #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minhir
reviewed
Jul 2, 2024
src/array/replace.ts
Outdated
| for (let index = 0; index < array.length; index++) { | ||
| const item = array[index] | ||
| if (match(item, index)) { | ||
| out.splice(index, 1, newItem) |
There was a problem hiding this comment.
Why not just out[index] = newItem? out is already a copy.
aleclarson
changed the title
Co-authored-by: Vladimir Ivakin <[email protected]>
Minhir
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
Generally speaking, a
spliceshould be better performance than allocating 2 arrays that will need to be garbage collected. Not sure how well the benchmarks detect GC-related perf issues, though.edit: @Minhir realized we could use basic assignment instead of
splice. 🎉Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No