refactor: move object functions using JSON paths to a new /object/path/ folder
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
refactor/move-path-related-functions
branch
from
da50efc to
b9abd7e
Compare
|
edit: Going with |
aleclarson
added
the
stage 0: proposed
aleclarson
force-pushed
the
refactor/move-path-related-functions
branch
from
b9abd7e to
44f2e72
Compare
aleclarson
changed the title
/object/path/ folder
Minhir
approved these changes
Jul 8, 2024
aleclarson
removed
the
stage 0: proposed
aleclarson
force-pushed
the
main
branch
2 times, most recently
from
2154f96 to
6a4b4f6
Compare
| export * from './object/shake.ts' | ||
| export * from './object/upperize.ts' | ||
|
|
||
| export * from './path/construct.ts' | ||
| export * from './path/crush.ts' | ||
| export * from './path/get.ts' |
There was a problem hiding this comment.
Suggested change
| export * from './path/get.ts' | |
| export * from './object/path/construct.ts' | |
| export * from './object/path/crush.ts' | |
| export * from './object/path/get.ts' | |
| export * from './object/path/keys.ts' | |
| export * from './object/path/set.ts |
MarlonPassos-git
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
The idea is to separate the object functions that work with JSON paths, since they're kind of in a category of their own. By separating them, it'll be easier to see the holes in this area of the API.
For any code change,
Does this PR introduce a breaking change?
No