fix(types): improve the isArray return type for unknown input type
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
fix/isArray-return-type
branch
from
9b69d1d to
18339dd
Compare
aleclarson
force-pushed
the
fix/isArray-return-type
branch
from
c2e51dd to
397d834
Compare
aleclarson
changed the title
isArray return type for unknown inputisArray return type for unknown input type
|
A new beta version To install: pnpm add [email protected]The 
|
aleclarson
added
upstream fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
This PR adds “type tests” for
isArray, showcasing its utility. See thetests/typed/isArray.test-d.tsfile. Notably, ourisArrayutility actually works with readonly arrays, whileArray.isArraydoes not.In addition, it improves the return type when the input value is typed
unknown. It now returns a mutable array type, instead of a readonly one. I believe this new behavior is the most common expectation of how it should work.For any code change,
Does this PR introduce a breaking change?
No