-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support iterables in places #90
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
feat/iterables
branch
2 times, most recently
from
July 7, 2024 20:17
db107f1
to
0775a84
Compare
aleclarson
force-pushed
the
main
branch
2 times, most recently
from
July 12, 2024 00:23
2154f96
to
6a4b4f6
Compare
aleclarson
added
new feature
This PR adds a new function or extends an existing one
stage 0: proposed
A proposal for a change that is offered for community and team evaluation.
labels
Jul 13, 2024
+76 bytes
+121 bytes
aleclarson
force-pushed
the
feat/iterables
branch
from
July 15, 2024 19:50
0775a84
to
015ab39
Compare
aleclarson
removed
the
stage 0: proposed
A proposal for a change that is offered for community and team evaluation.
label
Sep 21, 2024
aleclarson
added
rejected
A rejected proposal.
and removed
new feature
This PR adds a new function or extends an existing one
labels
Nov 20, 2024
Closing this, as I decided it's easy enough to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
castIterable
functionThis returns iterable objects as-is, otherwise returns
Object.entries
result.reduceIterable
functionsearchIterable
functionselect
selectFirst
cluster
counting
group
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/array/cluster.ts
src/array/counting.ts
src/array/group.ts
src/array/select.ts
src/array/selectFirst.ts
src/iterable/castIterable.ts
src/iterable/reduceIterable.ts
src/iterable/searchIterable.ts