feat: add ownProperties, ownPropertyNames, ownPropertyValues
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
feat/ownProperty-fns
branch
from
10449e0 to
ef76186
Compare
|
Unfortunately, we can't provide better typings for those functions compared to TS ones. There is an example of unexpected behavior with current types. |
|
Closing as per #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
Add 3 functions that mirror the behavior of
Object.entries,Object.keys, andObject.valuesbut do it lazily (via generator) and provide better type inference (see thetests/iterable/*.test-d.tsfiles for examples).No benchmarks added, since these implementations are so straight-forward and therefore very unlikely to be optimized.
For any code change,
Does this PR introduce a breaking change?
No