Skip to content
This repository has been archived by the owner on Dec 30, 2021. It is now read-only.

MiniPlayer Revision for Radiant Player 2.0 #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BarakaAka1Only
Copy link

Finally the MiniPlayer revision is here!! (Due note this is still in
its early stages; this has been tested heavily.)

Features:

  • Complete re-design of the MiniPlayer
  • RadiantTools (an extension tool for GMusic.js)
  • MiniPlayer Visualizations
  • Volume support
  • Drop menu for options
  • Artwork animations
  • Dock / Undock the MiniPlayer
  • IMFL (I'm Feeling Lucky ~ Roll the Dice)
  • Youtube w/ Fullscreen support
  • Drag support in an undocked state
  • Replay back 10 seconds / Forward 30 seconds actions

Remember this is in its early stages, if you encounter any issues
please report them! I did my best to kick out any issues making this as
smooth as possible.

This is going to be continuously worked on with other planned features
in the future.

Finally the MiniPlayer revision is here!! (Due note this is still in
its early stages; this has been tested heavily.)

Features:
- Complete re-design of the MiniPlayer
- RadiantTools (an extension tool for GMusic.js)
- MiniPlayer Visualizations
- Volume support
- Drop menu for options
- Artwork animations
- Dock / Undock the MiniPlayer
- IMFL (I'm Feeling Lucky ~ Roll the Dice)
- Youtube w/ Fullscreen support
- Drag support in an undocked state
- Replay back 10 seconds / Forward 30 seconds actions

Remember this is in its early stages, if you encounter any issues
please report them! I did my best to kick out any issues making this as
smooth as possible.

This is going to be continuously worked on with other planned features
in the future.
This fixes all ES-Lint issues as i forgot to run the lint test on the
last PR, this will fix it and this includes other changes!
Files didn’t upload properly
@MarshallOfSound
Copy link

I greatly enjoying spying on other repositories 😆 Just thought I'd drop in and say you should really avoid using executeJavascript at all costs. There are limited ways to catch errors using that method and any code you write for it is technically a string and therefore won't be linted.

@BarakaAka1Only
Copy link
Author

@MarshallOfSound hahah! Noted! The only main reason i am using executeJavascript is due to the way i am docking and undocking the windows, I am still relatively new to electron but for what it's worth it works. (for now)
Either way this is in its early stages, i couldn't think of a better way other than executeJavascript;
Hopefully someone can come up with something better but this is a start 😉

@MarshallOfSound
Copy link

@BarakaAka1Only TLDR anything that can be done with executeJavaScript can also be done with custom IPC messages. Send the message "dock" to the miniplayer and have the miniplayer listen for that message and run the logic you need it to.

@BarakaAka1Only
Copy link
Author

@MarshallOfSound i guess i am blind then 😶 that makes perfect sense. I'll have this adjusted then thank you!

@scififan2715
Copy link

I've built Radiant from your branch and am stuck on the "Setting up Google Play Music" page with the spinning record after pressing the "install miniplayer button

@BarakaAka1Only
Copy link
Author

@scififan2715 "install miniplayer button" is not the miniplayer at all, what you are doing is within GPM is the clicking on:

image

which that is for the Google Chrome extension. The Radiant Player MiniPlayer is built in meaning its on the Tray bar. Just click the Tray icon via

image

@scififan2715
Copy link

All fixed, I had compiled an older version by mistake, so I had the older miniplayer. Looks awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants