Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize callbacks execution #9

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

lucataglia
Copy link
Contributor

No description provided.

@lucataglia lucataglia requested a review from dvalleri June 28, 2024 09:23
@@ -107,7 +107,13 @@ export default <Values extends InitialValues>({
} = {},
action
) => {
const newUUID = uuidv4()
const newUUID = (function getUUID() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the function getUUID is reused in multiple places, can we move it to call it up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep the auto-invoking function there because of the readability

@lucataglia lucataglia merged commit e22d579 into main Jun 28, 2024
4 checks passed
@lucataglia lucataglia deleted the refactor/optimize-callbacks-execution branch June 28, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants