fix: percentage fix #206
Merged
fix: percentage fix #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivamarco
commented
Dec 9, 2024
| flagged_metrics / len(model_quality_reference) | ||
| ) | ||
| perc_model_quality["value"] = 1 - ( | ||
| flagged_metrics / len(model_quality_current["grouped_metrics"]) |
There was a problem hiding this comment.
the percentage is the number of "wrong" (flagged) metrics / the number of metrics that we have considered
rivamarco
commented
Dec 9, 2024
| ) | ||
| cumulative_sum += 1 - ( | ||
| flagged_metrics | ||
| / len(model_quality_reference["class_metrics"][0]["metrics"]) |
There was a problem hiding this comment.
For each class, we have the number of "wrong"/flagged metrics divided by the numer of the metrics, and we put this in an accumulator
rivamarco
commented
Dec 9, 2024
| ) | ||
| flagged_metrics = 0 | ||
| perc_model_quality["value"] = ( | ||
| cumulative_sum / len(model_quality_reference["classes"]) |
There was a problem hiding this comment.
Then the accumulator is divided by the number of classes
bigmoby
approved these changes
Dec 9, 2024
dtria91
approved these changes
Dec 9, 2024
maocorte
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed percentages that went above 100% or were wrong