Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operations to return WCS coordinates from argmin/argmax #665

Closed

Conversation

e-koch
Copy link
Contributor

@e-koch e-koch commented Sep 22, 2020

#656 needs to be merged before this!

Adds SpectralCube.argmin_world and SpectralCube.argmax_world to return the WCS coordinates of the argmin/max along a dimension. I've generalized a snippet from @low-sky for this.

The main use is creating "peak velocity" maps from a cube (i.e., velocity at peak intensity):

peak_velocity = cube.argmax_world(axis=0)
  • Add to docs pages
  • Finish docstrings

Sorry, something went wrong.

e-koch added 30 commits August 15, 2020 12:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… an additional message when strict mode is on
@coveralls
Copy link

coveralls commented Sep 22, 2020

Coverage Status

Coverage decreased (-1.7%) to 86.409% when pulling 94ffe27 on e-koch:add_spectral_peak_operations into df078f4 on radio-astro-tools:master.

@astrofrog
Copy link
Member

astrofrog commented Oct 1, 2020

I'll review once #656 is merged and this is rebased - please ping me then

@e-koch
Copy link
Contributor Author

e-koch commented Oct 22, 2020

Closing and moving to #680. This PR became overly complicated depending on #656

@e-koch e-koch closed this Oct 22, 2020
@e-koch e-koch deleted the add_spectral_peak_operations branch October 22, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants