-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operations to return WCS coordinates from argmin/argmax #665
Closed
e-koch
wants to merge
53
commits into
radio-astro-tools:master
from
e-koch:add_spectral_peak_operations
Closed
Add operations to return WCS coordinates from argmin/argmax #665
e-koch
wants to merge
53
commits into
radio-astro-tools:master
from
e-koch:add_spectral_peak_operations
+676
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine a common_beam for a VRSC
…th a DeprecationWarning
…w/ errors always raised)
… an additional message when strict mode is on
…be each option in the docstring
… to the 0th element
I'll review once #656 is merged and this is rebased - please ping me then |
This was referenced Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#656 needs to be merged before this!
Adds
SpectralCube.argmin_world
andSpectralCube.argmax_world
to return the WCS coordinates of the argmin/max along a dimension. I've generalized a snippet from @low-sky for this.The main use is creating "peak velocity" maps from a cube (i.e., velocity at peak intensity):