Skip to content

Commit

Permalink
Bump app.js size limit, always compare files in the PR with base
Browse files Browse the repository at this point in the history
  • Loading branch information
paskal committed Nov 3, 2024
1 parent cbb76e3 commit b6f671c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-build-site.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
id: get-comparison-commit
run: |
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo "compare_sha=$(git merge-base ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }})" >> $GITHUB_OUTPUT
echo "compare_sha=$(git rev-parse ${{ github.event.pull_request.base.sha }})" >> $GITHUB_OUTPUT
else
echo "compare_sha=$(git rev-parse HEAD^1)" >> $GITHUB_OUTPUT
fi
Expand Down Expand Up @@ -281,4 +281,4 @@ jobs:
comment-id: ${{ steps.find-comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
body: ${{ steps.get-comment-body.outputs.body }}${{ steps.get-comment-body-no-changes.outputs.body }}
edit-mode: replace
edit-mode: replace
2 changes: 1 addition & 1 deletion hugo/.size-limit.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = [
{
path: 'static/build/app.js',
limit: '17 KB',
limit: '20 KB',
},
{
path: 'static/build/manifest.js',
Expand Down

0 comments on commit b6f671c

Please sign in to comment.