Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wip #522

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@antoinegelloz antoinegelloz requested review from julienvey, graillus and a team as code owners April 25, 2024 08:31
@antoinegelloz antoinegelloz marked this pull request as draft April 25, 2024 08:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 55.51%. Comparing base (a1cc197) to head (bc74f28).

Files Patch % Lines
pkg/dag/printer.go 0.00% 65 Missing ⚠️
cmd/graph.go 0.00% 23 Missing ⚠️
pkg/dag/dag.go 0.00% 12 Missing ⚠️
pkg/dib/generate_dag.go 84.78% 4 Missing and 3 partials ⚠️
pkg/dag/node.go 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   57.67%   55.51%   -2.16%     
==========================================
  Files          50       52       +2     
  Lines        2294     2394     +100     
==========================================
+ Hits         1323     1329       +6     
- Misses        862      960      +98     
+ Partials      109      105       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinegelloz antoinegelloz force-pushed the FOND-3846-dib-build-detecter-les-images-en-doublon-pendant-la-generation-du-dag-et-renvoyer-une-erreur-a-lutilisateur branch 2 times, most recently from a29596b to 355dd16 Compare April 30, 2024 09:40
@antoinegelloz antoinegelloz force-pushed the FOND-3846-dib-build-detecter-les-images-en-doublon-pendant-la-generation-du-dag-et-renvoyer-une-erreur-a-lutilisateur branch from 355dd16 to bc74f28 Compare April 30, 2024 09:58
@antoinegelloz antoinegelloz changed the title fix: build: detect and prevent generating the graph when Dockerfiles have the same name fix: wip Apr 30, 2024
@antoinegelloz antoinegelloz deleted the FOND-3846-dib-build-detecter-les-images-en-doublon-pendant-la-generation-du-dag-et-renvoyer-une-erreur-a-lutilisateur branch April 30, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants