Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): remove golangci-lint skip-pkg-cache option #528

Conversation

antoinegelloz
Copy link
Contributor

@antoinegelloz antoinegelloz commented May 2, 2024

From release notes of golangci-lint action v5.0.0:

skip-pkg-cache and skip-build-cache have been removed because the cache related to Go itself is already handled by actions/setup-go.

@antoinegelloz antoinegelloz requested review from julienvey, graillus and a team as code owners May 2, 2024 08:08
@antoinegelloz antoinegelloz changed the title fix: actions: golangci-lint: remove deprecated skip-pkg-cache option fix: actions: golangci-lint: remove skip-pkg-cache option May 2, 2024
@antoinegelloz antoinegelloz force-pushed the fix/actions-golangci-lint-remove-deprecated-skip-pkg-cache-option branch from d726786 to bdfcd44 Compare May 2, 2024 08:38
@antoinegelloz antoinegelloz changed the title fix: actions: golangci-lint: remove skip-pkg-cache option fix(CI): remove golangci-lint skip-pkg-cache option May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.81%. Comparing base (fc11e0f) to head (bdfcd44).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   57.72%   57.81%   +0.08%     
==========================================
  Files          50       50              
  Lines        2297     2297              
==========================================
+ Hits         1326     1328       +2     
+ Misses        862      861       -1     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinegelloz antoinegelloz merged commit 0a719c4 into main May 2, 2024
5 checks passed
@antoinegelloz antoinegelloz deleted the fix/actions-golangci-lint-remove-deprecated-skip-pkg-cache-option branch May 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants