refact(GenerateDAG): new internal tests #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinegelloz
requested review from
julienvey,
graillus and
a team
as code owners
antoinegelloz
changed the title
antoinegelloz
requested review from
Thibaut-gauvin,
gminh474 and
joulaud
and removed request for
a team,
julienvey and
graillus
antoinegelloz
force-pushed
the
fix/GenerateDAG-new-tests
branch
from
93c08b4 to
e022570
Compare
antoinegelloz
force-pushed
the
fix/GenerateDAG-new-tests
branch
from
e022570 to
b6e58df
Compare
antoinegelloz
force-pushed
the
fix/GenerateDAG-new-tests
branch
from
b6e58df to
3931586
Compare
antoinegelloz
changed the title
antoinegelloz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is improving the testing of the current GenerateDAG algorithm, to show the different problems with it.
The current algorithm has been split in two:
A new internal test is proving that the first part is not working correctly, as some files are not assigned to the right nodes.