refact(GenerateDAG): split the algorithm in two parts #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinegelloz
requested review from
julienvey,
graillus and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 58.80% 58.94% +0.13%
==========================================
Files 51 51
Lines 2350 2353 +3
==========================================
+ Hits 1382 1387 +5
+ Misses 861 860 -1
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. |
antoinegelloz
requested review from
Thibaut-gauvin,
gminh474 and
joulaud
and removed request for
a team,
julienvey and
graillus
… computeHashes. The first buildGraph needs to be unit tested, because we found some issues with its logic.
antoinegelloz
force-pushed
the
refact/GenerateDAG-split
branch
from
47afcce to
0e6bb2b
Compare
|
LGTM, seems trivial, the separation between graph construction and hash generation seems a good idea. The tests are empty at the moment but I suppose they will be completed in following changes. |
Exactly :) |
Thibaut-gauvin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refact(GenerateDAG): split the algorithm in two parts, buildGraph and computeHashes.
The first part buildGraph needs to be unit tested, because we found some issues with its logic.