fix(GenerateDAG): new algorithm #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinegelloz
requested review from
julienvey,
graillus and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refact/more-precise-GenerateDAG-tests #609 +/- ##
========================================================================
Coverage ? 59.26%
========================================================================
Files ? 51
Lines ? 2391
Branches ? 0
========================================================================
Hits ? 1417
Misses ? 868
Partials ? 106 ☔ View full report in Codecov by Sentry. |
antoinegelloz
commented
Oct 9, 2024
| case filePath == buildPath: | ||
| return nil | ||
| case dirEntry.IsDir(): | ||
| if err := filepath.WalkDir(filePath, func(otherFile string, dirEntry os.DirEntry, err error) error { |
There was a problem hiding this comment.
Check here why we need the recursive WalkDir?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.