Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GenerateDAG): new algorithm and tests #614

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

antoinegelloz
Copy link
Contributor

@antoinegelloz antoinegelloz commented Oct 15, 2024

  • much more precise GenerateDAG tests cases
  • rewrite of GenerateDAG algorithm

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 79.02098% with 30 lines in your changes missing coverage. Please review.

Project coverage is 58.36%. Comparing base (afd0fe7) to head (b36be66).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dib/generate_dag.go 79.02% 20 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   57.90%   58.36%   +0.46%     
==========================================
  Files          51       51              
  Lines        2858     2868      +10     
==========================================
+ Hits         1655     1674      +19     
+ Misses       1097     1088       -9     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinegelloz antoinegelloz marked this pull request as draft October 15, 2024 14:54
@antoinegelloz antoinegelloz force-pushed the fix/GenerateDAG3 branch 2 times, most recently from 5ff6f7e to 1a2da66 Compare October 18, 2024 09:34
@antoinegelloz antoinegelloz marked this pull request as ready for review October 18, 2024 09:35
@Thibaut-gauvin Thibaut-gauvin merged commit 7f25170 into main Oct 28, 2024
5 checks passed
@Thibaut-gauvin Thibaut-gauvin deleted the fix/GenerateDAG3 branch October 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants