Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(GenerateDAG): general #615

Merged
merged 1 commit into from
Oct 18, 2024
Merged

refact(GenerateDAG): general #615

merged 1 commit into from
Oct 18, 2024

Conversation

antoinegelloz
Copy link
Contributor

  • rename some variables
  • make methods private when it makes sense
  • add context files to image instead of node
  • tests to internal

… it makes sense, add context files to image instead of node, tests to internal
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.96%. Comparing base (da3b77a) to head (e88f69b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dib/generate_dag.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   58.94%   58.96%   +0.01%     
==========================================
  Files          51       51              
  Lines        2353     2349       -4     
==========================================
- Hits         1387     1385       -2     
+ Misses        860      858       -2     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gminh474 gminh474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoinegelloz antoinegelloz merged commit cca351c into main Oct 18, 2024
5 checks passed
@antoinegelloz antoinegelloz deleted the refact/GenerateDAG branch October 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants