Update init experience #3933
Update init experience #3933
Conversation
| @@ -38,8 +38,7 @@ func SelectEnvironmentName(cmd *cobra.Command, defaultVal string, interactive bo | |||
| return "", err | |||
| } | |||
| if interactive && envStr == "" { | |||
| promptMsg := fmt.Sprintf("Enter an environment name [%s]:", defaultVal) | |||
| envStr, err = prompter.RunPrompt(prompt.TextPromptWithDefault(promptMsg, defaultVal, prompt.ResourceName)) | |||
| envStr, err = prompter.RunPrompt(prompt.TextPromptWithDefault("Enter an environment name", defaultVal, prompt.ResourceName)) | |||
There was a problem hiding this comment.
Because promptui already has a default experience, we don't need to manually build the prompt message with the default
| if strings.ToLower(confirmDefaultContext) == "y" { | ||
| return currentContext, nil | ||
| } | ||
| defaultValue := fmt.Sprintf("%s (current)", currentContext) |
There was a problem hiding this comment.
Simplify selection process by placing current at the top and appending (current), and just using a selection prompt
There was a problem hiding this comment.
Love it. This is one of the ideas we discussed a few weeks ago, glad to see it come back.
There was a problem hiding this comment.
The tests might fail though because it is one skipped terminal interaction.
There was a problem hiding this comment.
Yep, getting this error:
=== RUN Test_Validate/Valid_Init_Command
shared.go:73: assertion failed: expected error to contain "cluster unreachable", got "KubeContext not specified": Error should be: kubernetes cluster unreachable, got: KubeContext not specified
|
/cc @bjoginapally |
|
Double prompts are caused by manifoldco/promptui#129, which has an open PR. Just pinged the maintainers to review. |
| @@ -76,6 +74,7 @@ func SelectNamespace(cmd *cobra.Command, defaultVal string, interactive bool, pr | |||
| } | |||
| return nil | |||
| }, | |||
| AllowEdit: true, | |||
There was a problem hiding this comment.
This places the cursor at the end of the line instead of the beginning
There was a problem hiding this comment.
In the other case, the user can either press enter or start typing. In this case the user will have to clear the default first?
There was a problem hiding this comment.
Correct, in the old case you could start typing and it would clear the current entry. In this new case you have to hit backspace to clear it out manually and then type the new name.
Given that the cursor blocks out the first character, I think this change is preferrable.
There was a problem hiding this comment.
As an alternative we can switch to https://github.com/charmbracelet/bubbletea, which has better support for default values (greyed out text)
There was a problem hiding this comment.
Agree cursor blocking is not great. LGTM.
* Fix double semicolon and cursor location * Update kubeconfig selection logic * Auto formatting * Correct integration tests Co-authored-by: Bharath Joginapally <[email protected]>
Description
Issue reference
Partially addresses
Partially fixes: radius-project/core-team#946
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: