Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions and config for required local dotnet version #8213

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

kachawla
Copy link
Contributor

@kachawla kachawla commented Jan 9, 2025

Description

DE was updated to .net 8 in https://github.com/radius-project/deployment-engine/pull/394. Similar version is needed to run control plane locally, updating instructions and launch.json to reflect that as the setup is broken with current instructions due to version mismatch.

Validated updated config locally.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • [N/A] An overview of proposed schema changes is included in a linked GitHub issue.
  • [N/A] A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • [N/A] If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • [N/A] A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • [N/A] A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • [N/A] A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@kachawla kachawla requested review from a team as code owners January 9, 2025 02:15
@kachawla kachawla temporarily deployed to functional-tests January 9, 2025 02:16 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 9, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 4c0cc33
Unique ID funcf980d9e61c
Image tag pr-funcf980d9e61c
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf980d9e61c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf980d9e61c
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcf980d9e61c
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf980d9e61c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf980d9e61c
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

@kachawla kachawla changed the title Update instructions for required dotnet version Update instructions and config for required dotnet version Jan 9, 2025
@kachawla kachawla changed the title Update instructions and config for required dotnet version Update instructions and config for required local dotnet version Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.75%. Comparing base (9fcb182) to head (c1074c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8213   +/-   ##
=======================================
  Coverage   59.75%   59.75%           
=======================================
  Files         590      590           
  Lines       39487    39487           
=======================================
+ Hits        23594    23597    +3     
+ Misses      14148    14146    -2     
+ Partials     1745     1744    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 9, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref c1074c3
Unique ID funcf7da35f0d1
Image tag pr-funcf7da35f0d1
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf7da35f0d1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf7da35f0d1
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcf7da35f0d1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf7da35f0d1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf7da35f0d1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla kachawla merged commit 1b47609 into radius-project:main Jan 9, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants