Reapply UDT - Remove Legacy Routing #8275

lakshmimsft · 2025-01-22T17:59:49Z

Description

Commit for PR #8205 is being reinstated with updates to cloud and non-cloud test workflows.
The updates to the workflows are in commit 940a693.

Original PR Description:

Remove Legacy Routing. Update tests as necessary
Add global location, address to manifests. Include them in ucp images.

Type of change

This pull request adds or changes features of Radius and has an approved issue (User-Defined Resource Types #6688 ).

Part of: #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests · 2025-01-22T18:04:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`1fd0229`
Unique ID	func50b373079b
Image tag	pr-func50b373079b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func50b373079b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func50b373079b
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func50b373079b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func50b373079b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func50b373079b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

github-actions · 2025-01-22T18:15:14Z

Unit Tests

3 552 tests - 10 3 548 ✅ - 10 5m 26s ⏱️ +7s
292 suites ± 0 4 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit 197ef9a. ± Comparison against base commit da85dab.

This pull request removes 10 tests.

github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/legacy_resource_provider_not_configured
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/location_not_found
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/plane_not_found
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/plane_retrieval_failure
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/resource_group_err
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/resource_group_not_found
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/resource_provider_invalid_URL
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/success_(non_resource_group)
github.com/radius-project/radius/pkg/ucp/frontend/controller/resourcegroups ‑ Test_ValidateDownstream_Legacy/success_(resource_group)

♻️ This comment has been updated with latest results.

codecov · 2025-01-22T18:16:14Z

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.83%. Comparing base (da85dab) to head (197ef9a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/manifest/registermanifest.go	90.62%	1 Missing and 2 partials ⚠️
pkg/ucp/frontend/controller/resourcegroups/util.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8275   +/-   ##
=======================================
  Coverage   59.82%   59.83%           
=======================================
  Files         590      590           
  Lines       39520    39513    -7     
=======================================
- Hits        23644    23642    -2     
+ Misses      14120    14112    -8     
- Partials     1756     1759    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Description 1. Remove Legacy Routing. Update tests as necessary 2. Add global location, address to manifests. Include them in ucp images. ## Type of change - This pull request adds or changes features of Radius and has an approved issue (#6688 ). Part of: #6688 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [ ] An overview of proposed schema changes is included in a linked GitHub issue. - [ ] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. - [ ] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. --------- Signed-off-by: lakshmimsft <[email protected]>

radius-functional-tests · 2025-01-23T00:24:01Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`940a693`
Unique ID	func1564e06da5
Image tag	pr-func1564e06da5

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1564e06da5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1564e06da5
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1564e06da5
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1564e06da5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1564e06da5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

lakshmimsft · 2025-01-23T00:37:08Z

@nithyatsu , @ytimocin: Commit for PR #8205 is being reinstated with updates to cloud and non-cloud test workflows.
The updates to the workflows are in commit 197ef9a.

Signed-off-by: lakshmimsft <[email protected]>

radius-functional-tests · 2025-01-23T01:04:11Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`197ef9a`
Unique ID	func20e49efc29
Image tag	pr-func20e49efc29

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func20e49efc29
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func20e49efc29
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func20e49efc29
controller test image location: ghcr.io/radius-project/dev/controller:pr-func20e49efc29
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func20e49efc29
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

nithyatsu

talked online for questions. lgtm.

lakshmimsft requested a deployment to functional-tests January 22, 2025 17:59 — with GitHub Actions Waiting

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 18:00 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 22, 2025 18:02 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 18:03 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from 1fd0229 to 6d0071b Compare January 22, 2025 21:48

lakshmimsft requested a deployment to functional-tests January 22, 2025 21:48 — with GitHub Actions Waiting

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 21:48 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from 6d0071b to 7b5fa30 Compare January 22, 2025 22:04

lakshmimsft requested a deployment to functional-tests January 22, 2025 22:04 — with GitHub Actions Waiting

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 22:04 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from 7b5fa30 to accff5c Compare January 22, 2025 22:32

lakshmimsft requested a deployment to functional-tests January 22, 2025 22:33 — with GitHub Actions Waiting

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 22:33 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from accff5c to da58a0d Compare January 22, 2025 23:35

lakshmimsft requested a deployment to functional-tests January 22, 2025 23:35 — with GitHub Actions Waiting

lakshmimsft had a problem deploying to publish-bicep January 22, 2025 23:35 — with GitHub Actions Error

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from da58a0d to 9a6150b Compare January 22, 2025 23:35

lakshmimsft requested a deployment to functional-tests January 22, 2025 23:36 — with GitHub Actions Waiting

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 23:36 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from 9a6150b to c2d25fc Compare January 22, 2025 23:57

lakshmimsft requested a deployment to functional-tests January 22, 2025 23:57 — with GitHub Actions Waiting

lakshmimsft temporarily deployed to publish-bicep January 22, 2025 23:57 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from c2d25fc to 940a693 Compare January 23, 2025 00:16

lakshmimsft temporarily deployed to functional-tests January 23, 2025 00:16 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep January 23, 2025 00:16 — with GitHub Actions Inactive

lakshmimsft changed the title ~~[WIP] UDT - Remove Legacy Routing (Test Cloud Func Test)~~ Reapply UDT - Remove Legacy Routing Jan 23, 2025

lakshmimsft marked this pull request as ready for review January 23, 2025 00:34

lakshmimsft requested review from a team as code owners January 23, 2025 00:34

upd with explicit err check

197ef9a

Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft force-pushed the lakshmimsft/testcloudfuncwrkflow branch from 940a693 to 197ef9a Compare January 23, 2025 00:48

lakshmimsft temporarily deployed to functional-tests January 23, 2025 00:48 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep January 23, 2025 00:48 — with GitHub Actions Inactive

nithyatsu approved these changes Jan 23, 2025

View reviewed changes

nithyatsu merged commit 9af20f3 into main Jan 23, 2025
37 checks passed

nithyatsu deleted the lakshmimsft/testcloudfuncwrkflow branch January 23, 2025 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reapply UDT - Remove Legacy Routing #8275

Reapply UDT - Remove Legacy Routing #8275

lakshmimsft commented Jan 22, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading

lakshmimsft commented Jan 23, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading

nithyatsu left a comment

Reapply UDT - Remove Legacy Routing #8275

Reapply UDT - Remove Legacy Routing #8275

Conversation

lakshmimsft commented Jan 22, 2025 • edited Loading

Description

Type of change

Contributor checklist

radius-functional-tests bot commented Jan 22, 2025 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jan 22, 2025 • edited Loading

Unit Tests

codecov bot commented Jan 22, 2025 • edited Loading

Codecov Report

radius-functional-tests bot commented Jan 23, 2025 • edited Loading

Radius functional test overview

Test Status

lakshmimsft commented Jan 23, 2025 • edited Loading

radius-functional-tests bot commented Jan 23, 2025 • edited Loading

Radius functional test overview

Test Status

nithyatsu left a comment

Choose a reason for hiding this comment

lakshmimsft commented Jan 22, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading

lakshmimsft commented Jan 23, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading