-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add purge job for bicep artifacts #8281
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: sk593 <[email protected]>
Unit Tests3 552 tests 3 548 ✅ 5m 23s ⏱️ Results for commit 854eb44. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8281 +/- ##
==========================================
- Coverage 59.81% 59.81% -0.01%
==========================================
Files 590 590
Lines 39513 39513
==========================================
- Hits 23636 23633 -3
- Misses 14116 14118 +2
- Partials 1761 1762 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
- name: Login to Azure | ||
uses: azure/login@v2 | ||
with: | ||
client-id: ${{ secrets.BICEPTYPES_CLIENT_ID }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need separate accounts for different operations? The other purge action uses AZURE_SP_TESTS_APPID
. Wouldn't having one shared be better for actions that can be grouped together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ACR is in a different account than the other Azure resources so we need different credentials to authenticate
Description
This adds a purge job for test bicep artifacts. It will delete any manifests that are older than 90 days. This only applies to the test schemas uploaded as part of PRs, not any major release versions of Radius or AWS bicep types.
A successful test run can be found here: https://github.com/radius-project/radius/actions/runs/12939411131
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: