Restore bicep artifacts before starting tests #8283

sk593 · 2025-01-23T17:49:05Z

Description

This change restores Bicep artifacts before running any tests. This will avoid any restoration errors while the tests are running as seen in #8184

Type of change

This pull request fixes a bug in Radius and has an approved issue Flaky test: Failed to restore AWS bicep artifact #8184
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #8184

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
[ ]

Signed-off-by: sk593 <[email protected]>

github-actions · 2025-01-23T18:03:03Z

Unit Tests

3 552 tests 3 548 ✅ 5m 21s ⏱️
292 suites 4 💤
1 files 0 ❌

Results for commit a000290.

♻️ This comment has been updated with latest results.

codecov · 2025-01-23T18:04:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (7797bb0) to head (a000290).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8283      +/-   ##
==========================================
+ Coverage   59.81%   59.83%   +0.01%     
==========================================
  Files         590      590              
  Lines       39513    39513              
==========================================
+ Hits        23636    23642       +6     
+ Misses      14116    14112       -4     
+ Partials     1761     1759       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brooke-hamilton

I tested this locally - 🚀 🛰️

Signed-off-by: sk593 <[email protected]>

radius-functional-tests · 2025-01-23T23:54:57Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`e2a499b`
Unique ID	func3738baaafb
Image tag	pr-func3738baaafb

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3738baaafb
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3738baaafb
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func3738baaafb
controller test image location: ghcr.io/radius-project/dev/controller:pr-func3738baaafb
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3738baaafb
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2025-01-24T05:37:37Z

.github/workflows/functional-test-cloud.yaml

+          # Restore Radius Bicep types
+          bicep build ./test/functional-portable/corerp/cloud/resources/testdata/corerp-azure-connection-database-service.bicep
+          # Restore AWS Bicep types 
+          bicep build ./test/functional-portable/corerp/cloud/resources/testdata/aws-s3-bucket.bicep


Do the tests need the files generated by these two commands to be able to run successfully? If so, should we add those files to the repository itself?

I think that to be able to run these tests locally, this is also something we need to run. Is that right?

No, they're not needed. They're an output of the build command but we're more interested in the artifacts being restored in this step.

Yes to the second question. The bicep build command gets run when we deploy bicep templates. bicep build automatically restores the artifacts which might be why we've been seeing flaky restoration failures. This change is added so the bicep artifacts are restored before the tests start and bicep build is run

radius-functional-tests · 2025-01-24T18:33:00Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`0255e45`
Unique ID	func653d6c07ac
Image tag	pr-func653d6c07ac

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func653d6c07ac
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func653d6c07ac
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func653d6c07ac
controller test image location: ghcr.io/radius-project/dev/controller:pr-func653d6c07ac
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func653d6c07ac
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: sk593 <[email protected]>

radius-functional-tests · 2025-01-24T19:22:42Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`a000290`
Unique ID	func0d0ae104c8
Image tag	pr-func0d0ae104c8

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0d0ae104c8
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0d0ae104c8
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func0d0ae104c8
controller test image location: ghcr.io/radius-project/dev/controller:pr-func0d0ae104c8
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0d0ae104c8
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

restore bicep artifacts before starting tests

e8f3fdf

Signed-off-by: sk593 <[email protected]>

sk593 requested review from a team as code owners January 23, 2025 17:49

sk593 requested a deployment to functional-tests January 23, 2025 17:49 — with GitHub Actions Waiting

sk593 temporarily deployed to publish-bicep January 23, 2025 17:49 — with GitHub Actions Inactive

brooke-hamilton previously approved these changes Jan 23, 2025

View reviewed changes

sk593 dismissed brooke-hamilton’s stale review via d0533fd January 23, 2025 23:42

testing

d0533fd

Signed-off-by: sk593 <[email protected]>

sk593 requested a deployment to functional-tests January 23, 2025 23:42 — with GitHub Actions Waiting

sk593 temporarily deployed to publish-bicep January 23, 2025 23:42 — with GitHub Actions Inactive

revert

b04c3e7

Signed-off-by: sk593 <[email protected]>

sk593 requested a deployment to functional-tests January 23, 2025 23:50 — with GitHub Actions Waiting

nit

c8123fe

Signed-off-by: sk593 <[email protected]>

sk593 requested a deployment to functional-tests January 23, 2025 23:51 — with GitHub Actions Waiting

sk593 had a problem deploying to publish-bicep January 23, 2025 23:51 — with GitHub Actions Error

Merge branch 'main' into fix-flaky-aws-restoration

e2a499b

sk593 temporarily deployed to functional-tests January 23, 2025 23:51 — with GitHub Actions Inactive

sk593 temporarily deployed to publish-bicep January 23, 2025 23:51 — with GitHub Actions Inactive

brooke-hamilton previously approved these changes Jan 24, 2025

View reviewed changes

ytimocin reviewed Jan 24, 2025

View reviewed changes

Merge branch 'main' into fix-flaky-aws-restoration

0255e45

sk593 temporarily deployed to functional-tests January 24, 2025 18:01 — with GitHub Actions Inactive

sk593 temporarily deployed to publish-bicep January 24, 2025 18:01 — with GitHub Actions Inactive

sk593 dismissed brooke-hamilton’s stale review via 7654a24 January 24, 2025 18:56

update to restore

7654a24

Signed-off-by: sk593 <[email protected]>

sk593 requested a deployment to functional-tests January 24, 2025 18:56 — with GitHub Actions Waiting

sk593 temporarily deployed to publish-bicep January 24, 2025 18:56 — with GitHub Actions Inactive

nit

71d2e24

Signed-off-by: sk593 <[email protected]>

sk593 requested a deployment to functional-tests January 24, 2025 19:04 — with GitHub Actions Waiting

sk593 temporarily deployed to publish-bicep January 24, 2025 19:04 — with GitHub Actions Inactive

revert

a000290

Signed-off-by: sk593 <[email protected]>

sk593 temporarily deployed to functional-tests January 24, 2025 19:20 — with GitHub Actions Inactive

sk593 temporarily deployed to publish-bicep January 24, 2025 19:20 — with GitHub Actions Inactive

brooke-hamilton approved these changes Jan 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore bicep artifacts before starting tests #8283

Restore bicep artifacts before starting tests #8283

sk593 commented Jan 23, 2025

github-actions bot commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading

brooke-hamilton left a comment

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading

ytimocin Jan 24, 2025

sk593 Jan 24, 2025

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

Restore bicep artifacts before starting tests #8283

Are you sure you want to change the base?

Restore bicep artifacts before starting tests #8283

Conversation

sk593 commented Jan 23, 2025

Description

Type of change

Contributor checklist

github-actions bot commented Jan 23, 2025 • edited Loading

Unit Tests

codecov bot commented Jan 23, 2025 • edited Loading

Codecov Report

brooke-hamilton left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 23, 2025 • edited Loading

Radius functional test overview

Test Status

ytimocin Jan 24, 2025

Choose a reason for hiding this comment

sk593 Jan 24, 2025

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading