feat(popover): add cdk events service

[pawel-twardziak]

Description

feat(popover): add cdk events service

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocks-showcase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 7:37am
primitives	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 7:37am
radix-astro-doc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 7:37am
shadcn-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 7:37am
taxonomy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 7:37am

[vercel]

@pawel-twardziak is attempting to deploy a commit to the Radix-angular Team on Vercel.

A member of the Team first needs to authorize it.

[pawel-twardziak]

@pimenovoleg I've just reproduced the issue you talked about before :) the scrollbar appears and disappears quickly making the popover position wrongly computed. Interesting issue.

Primitives._.Popover.-.Docs.Storybook.-.Google.Chrome.2024-12-21.18-47-57.mp4

[pawel-twardziak]

the message box is suspicious imho

[pawel-twardziak]

@radix-ng/core @radix-ng/maintainers

Seems like it works like a charm :)

Film.bez.tytulu.mp4

Film.bez.tytulu.1.mp4

[pimenovoleg]

Looks awesome!

Can we make this optional? Something like a feature flag that needs to be enabled (off by default).
Like provideExperimentalZonelessChangeDetection :)

I'm a bit concerned about shadowDOM in MFE and potential side effects.
This is a great solution for improving UX, but I worry not everyone might be ready for it right away :)

@pawel-twardziak what do you think? or enable by default?

[pawel-twardziak]

Looks awesome!

Can we make this optional? Something like a feature flag that needs to be enabled (off by default). Like provideExperimentalZonelessChangeDetection :)

I'm a bit concerned about shadowDOM in MFE and potential side effects. This is a great solution for improving UX, but I worry not everyone might be ready for it right away :)

@pawel-twardziak what do you think? or enable by default?

Yep true, shadowDom would get some side effects, good point @pimenovoleg 👍
But in general, in context of MFE, that service would be a global and shared one - and the primitives might know nothing about the service then which means the service should not couple itself and the primitive but should be built on top of the promitives so that the primitives don't know about the service.

I will make it internal feature, only for the storybook purposes and will decouple the primitives from the service. The service itself will find and register the prmitives - that would make the service more MFE ready for the future :)

And also will make the service global and experimental, to be provided for playing with it. Documentation will be included.
We will see where it goes. We migth keep and release it or get rid of it in the future :)

UPDATE: it is already an internal feature as I haven't exposed the service yet :) And it is already optional. The service is provided in the storybook stuff. If we don't provide it, nothing will happen because the injection is optional.

@pimenovoleg does it make sense? :)

[pimenovoleg]

Looks awesome!
Can we make this optional? Something like a feature flag that needs to be enabled (off by default). Like provideExperimentalZonelessChangeDetection :)
I'm a bit concerned about shadowDOM in MFE and potential side effects. This is a great solution for improving UX, but I worry not everyone might be ready for it right away :)
@pawel-twardziak what do you think? or enable by default?

Yep true, shadowDom would get some side effects, good point @pimenovoleg 👍 But in general, in context of MFE, that service would be a global and shared one - and the primitives might know nothing about the service then which means the service should not couple itself and the primitive but should be built on top of the promitives so that the primitives don't know about the service.

I will make it internal feature, only for the storybook purposes and will decouple the primitives from the service. The service itself will find and register the prmitives - that would make the service more MFE ready for the future :)

And also will make the service global and experimental, to be provided for playing with it. Documentation will be included. We will see where it goes. We migth keep and release it or get rid of it in the future :)

UPDATE: it is already an internal feature as I haven't exposed the service yet :) And it is already optional. The service is provided in the storybook stuff. If we don't provide it, nothing will happen because the injection is optional.

@pimenovoleg does it make sense? :)

Thanks for the detailed explanation, that makes a lot of sense! 👍

I really like the approach of keeping the service decoupled from the primitives and making it global and experimental for now. It sounds like a solid way to test it without introducing too many risks upfront, especially in the context of MFE.

The fact that the injection is optional and only used in Storybook for now is great—it minimizes potential side effects while still allowing us to experiment and gather feedback.

Looking forward to seeing how it evolves! Let’s keep it iterative and adjust as we learn more. Thanks for considering all these edge cases! 😊

[pimenovoleg]

@pawel-twardziak
It seems like everything is ready for the current version. Do you have any additional thoughts or suggestions to add?

[pawel-twardziak]

yes, this version is ready @pimenovoleg 👍 But I want to:

1. make it global
2. ready to use with MFE
3. experimental (providers for both regular SPA and MFE environment)
4. decouple primitives from the service but build on top of them (there will be yet another dediceted directive to do so)
5. add docs with some examples of how to play with the service in SPA or MFE (out of the box by using the directive or utilizing the service in a custom way)

So, we can either merge this PR as it is only for stories so far and do the above later on or wait for the merge to do the above.
What are you recommending now? :)

[pawel-twardziak]

Ok, let's merge it :)