Hotfix 1.11.1 #1279
Hotfix 1.11.1 #1279
Conversation
| incomingRequestRepository.requestHandled(args.interactionId) | ||
| sendEvent(Event.Dismiss) |
There was a problem hiding this comment.
tbh i remember having some issues in the past with the order of those two but I can't remember what was exactly and if it was for transaction review screen or for the dapplogin screens.
is there any way we can test this?
Did you have the chance to test it?
There was a problem hiding this comment.
Yeap, I tested this, you can test it too by following these steps: disable 3rd party deposits for an account, go to another account settings with assets and choose to delete it -> when asked to move assets to another account choose the one with the 3rd party deposits disallowed and tap continue -> you're going to see the tx review screen with an error -> when tapping it it goes through this code which dismisses the screen and marks the request as handled.
There was a problem hiding this comment.
Also, you can see in TransactionSubmitDelegate.onDismiss that the Dismiss event is sent before marking the request as handled, just like here.
There was a problem hiding this comment.
Although I agree that it would make more sense first to mark the request as handled and then sending the dismiss event.
…sification Non-enclosed pre-auth classification
sergiupuhalschi-rdx
changed the title
|
|
Closing in favor of #1286 to have the changes on top of the 1.11.0 tag commit. |
Description
DappRequestException, for exampleReceivingAccountDoesNotAllowDepositsis encountered.